Clean up the `HISTIGNORE` Bash variable #115

xty · 2023-03-04T23:34:04Z

The following passage from the Bash Reference Manual provides justification for the proposed changes:

HISTIGNORE subsumes the function of HISTCONTROL. A pattern of ‘&’ is identical to ignoredups, and a pattern of ‘[ ]*’ is identical to ignorespace. Combining these two patterns, separating them with a colon, provides the functionality of ignoreboth.

The relevant section as it stands:

dotfiles/.bash_profile

Lines 57 to 63 in 8936892

    
           export HISTCONTROL="ignoredups"       # no duplicate entries, but keep space-prefixed commands 
        
           export HISTSIZE=100000                          # big big history (default is 500) 
        
           export HISTFILESIZE=$HISTSIZE                   # big big history 
        
           type shopt &> /dev/null && shopt -s histappend  # append to history, don't overwrite it 
        
           # Don't record some commands 
        
           export HISTIGNORE="&:[ ]*:exit:ls:bg:fg:history:clear"

Specifically, this PR is aimed at ironing out these kinks:

Having both & in HISTIGNORE and ignoredups in HISTCONTROL is redundant.
Assuming the intention was to preserve commands with a leading space (as indicated by the comment in Line 57), the inclusion of [ ]* in HISTIGNORE would be self-defeating.

* preserve commands with a leading space in Bash history as intended * remove the `&` pattern which serves the same purpose of `ignoredups`

clean up HISTIGNORE

9b09534

* preserve commands with a leading space in Bash history as intended * remove the `&` pattern which serves the same purpose of `ignoredups`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up the `HISTIGNORE` Bash variable #115

Clean up the `HISTIGNORE` Bash variable #115

xty commented Mar 4, 2023 •

edited

Loading

	export HISTCONTROL="ignoredups" # no duplicate entries, but keep space-prefixed commands
	export HISTSIZE=100000 # big big history (default is 500)
	export HISTFILESIZE=$HISTSIZE # big big history
	type shopt &> /dev/null && shopt -s histappend # append to history, don't overwrite it

	# Don't record some commands
	export HISTIGNORE="&:[ ]*:exit:ls:bg:fg:history:clear"

Clean up the HISTIGNORE Bash variable #115

Are you sure you want to change the base?

Clean up the HISTIGNORE Bash variable #115

Conversation

xty commented Mar 4, 2023 • edited Loading

Clean up the `HISTIGNORE` Bash variable #115

Clean up the `HISTIGNORE` Bash variable #115

xty commented Mar 4, 2023 •

edited

Loading